typo fix for "go to subscription" button#73269
Conversation
|
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 98d70664..95c49b5e 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -5732,7 +5732,7 @@ ${amount} für ${merchant} - ${date}`,
chatWithYourAdmin: 'Mit Ihrem Administrator chatten',
chatInAdmins: 'Im #admins chatten',
addPaymentCard: 'Zahlungskarte hinzufügen',
- goToSubscription: 'Zu den Abonnements',
+ goToSubscription: 'Zum Abonnement',
},
rules: {
individualExpenseRules: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index e98ae1d6..a1e3ed9c 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5738,7 +5738,7 @@ ${amount} pour ${merchant} - ${date}`,
chatWithYourAdmin: 'Discutez avec votre administrateur',
chatInAdmins: 'Discuter dans #admins',
addPaymentCard: 'Ajouter une carte de paiement',
- goToSubscription: 'Aller aux abonnements',
+ goToSubscription: "Accéder à l'abonnement",
},
rules: {
individualExpenseRules: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 4cd2df3c..86001742 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -5741,7 +5741,7 @@ ${amount} per ${merchant} - ${date}`,
chatWithYourAdmin: 'Chatta con il tuo amministratore',
chatInAdmins: 'Chatta in #admins',
addPaymentCard: 'Aggiungi carta di pagamento',
- goToSubscription: 'Vai agli abbonamenti',
+ goToSubscription: "Vai all'abbonamento",
},
rules: {
individualExpenseRules: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index bc3f9c88..85e1dacc 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5729,7 +5729,7 @@ ${amount} voor ${merchant} - ${date}`,
chatWithYourAdmin: 'Chat met je beheerder',
chatInAdmins: 'Chat in #admins',
addPaymentCard: 'Betaalpas toevoegen',
- goToSubscription: 'Ga naar abonnementen',
+ goToSubscription: 'Ga naar het abonnement',
},
rules: {
individualExpenseRules: {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index e7de83f5..0c9d89c0 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -5724,7 +5724,7 @@ ${amount} para ${merchant} - ${date}`,
chatWithYourAdmin: 'Converse com seu administrador',
chatInAdmins: 'Converse em #admins',
addPaymentCard: 'Adicionar cartão de pagamento',
- goToSubscription: 'Ir para Assinaturas',
+ goToSubscription: 'Ir para a assinatura',
},
rules: {
individualExpenseRules: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
da30c21 to
50b60c7
Compare
Codecov Report❌ Patch coverage is
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Pasting this to pass the test. No C+ needed since it's only a copy change. Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.38-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.38-5 🚀
|
Explanation of Change
https://expensify.slack.com/archives/C07J32337/p1761175435748199?thread_ts=1761153133.451829&cid=C07J32337
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop